Bug 955 - Cannot connect to another workrave over the network
Status:
RESOLVED FIXED
Component:
Core
Version:
1.9.3
Hardware:
PC Linux
Importance:
P5 major
Target Milestone:
---
Assignee:
Rob Caelers
URL:
Depends on:
Blocks:
Reported:
Dec 22 2010 03:32:14 UTC
by:
Francois Marier
Modified:
Jan 9 2011 20:10:20 UTC
| Who | When | What | Removed | Added |
|---|---|---|---|---|
| Rob Caelers | Jan 5 2011 20:56:41 UTC | status | NEW | ASSIGNED |
| Rob Caelers | Jan 9 2011 20:10:20 UTC | status | ASSIGNED | RESOLVED |
| resolution | FIXED |
Description
Francois Marier Dec 22 2010 03:32:14 UTC
As I was preparing an updated workrave package for Debian, I noticed that network connections no longer work in 1.9.3. After upgrading my 1.9.1 on the client (the server is still running 1.9.1), the 1.9.3 client can no longer connect to the server. There is nothing in the network log other than "Connecting to servername". Downgrading the client back to 1.9.1 solves the problem. The configuration has not changed at all. Let me know if there's anything else I can provide you that would be useful in debugging this.
Comment 1
Rob Caelers Jan 5 2011 20:56:41 UTC
It seems you can connect from 1.9.1 to 1.9.3, but not the other way (1.9.3 -> 1.9.3 is probably also broken...) commit aa6450ccc8749106749daa6064bb200b9f69e935 should fix this (this fix needs some more testing, so i'm not resolving it yet).
Comment 2
Francois Marier Jan 5 2011 23:37:33 UTC
I've applied that commit on top of the 1.9.3 and it seems to work now. Here's a network log of me starting the server, starting the client, closing the client, then starting the client again: [06/01/2011 11:30:54] Network operation started. [06/01/2011 11:31:05] Accepted new client. [06/01/2011 11:31:05] Client 448c37e6c0b43086d68ac9ec4d24ef74:27273 saying hello. [06/01/2011 11:31:20] Rejecting master request from client 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:31:25] Rejecting master request from client 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:31:35] Rejecting master request from client 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:33:34] Rejecting master request from client 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:33:53] Rejecting master request from client 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:34:12] Client 448c37e6c0b43086d68ac9ec4d24ef74:27273 closed connection. [06/01/2011 11:34:12] Disconnecting 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:34:19] Accepted new client. [06/01/2011 11:34:19] Client 448c37e6c0b43086d68ac9ec4d24ef74:27273 saying hello. [06/01/2011 11:34:19] Removing client 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:34:22] Acknowledging master request from client 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:34:25] Requesting master status from 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:34:25] Client 192.168.2.2:27273 is now the new master. [06/01/2011 11:34:25] I'm now master. [06/01/2011 11:34:32] Rejecting master request from client 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:34:51] Rejecting master request from client 448c37e6c0b43086d68ac9ec4d24ef74:27273. [06/01/2011 11:35:01] Rejecting master request from client 448c37e6c0b43086d68ac9ec4d24ef74:27273.
Comment 3
Rob Caelers Jan 9 2011 20:10:20 UTC
Thanks for testing! Disconnecting can lead to a crash. commit bdd8bbd8fb0599e99d6347ad402ed384eda65871 fixes this crash. Commit 6862351b5d9b71158419a396271d05b4bf1d5905 fixes some other disconnect problems.