Bug 90 - Change behaviour of "max_preludes"
Status:
VERIFIED FIXED
Component:
Core
Version:
unspecified
Hardware:
PC Other
Importance:
P2 normal
Target Milestone:
---
Assignee:
Rob Caelers
URL:
Depends on:
Blocks:
Reported:
Sep 18 2002 12:12:31 UTC
by:
Raymond Penners
Modified:
Nov 16 2002 04:21:37 UTC
WhoWhenWhatRemovedAdded
Raymond PennersSep 14 2002 20:27:29 UTCblocks45
Raymond PennersSep 18 2002 13:31:09 UTCblocks83
Rob CaelersSep 20 2002 09:23:09 UTCstatusNEWRESOLVED
resolutionFIXED
Kees-Jan DijkzeulSep 23 2002 02:24:26 UTCstatusRESOLVEDREOPENED
resolutionFIXED
Rob CaelersSep 25 2002 13:39:56 UTCstatusREOPENEDRESOLVED
resolutionFIXED
Kees-Jan DijkzeulNov 16 2002 04:21:37 UTCstatusRESOLVEDVERIFIED
Description
Raymond Penners  Sep 18 2002 12:12:32 UTC
I would like to see the behaviour of the "max_preludes" setting change:
- a value < 0 indicates an unlimited number of preludes
- a value of 0 disables preludes
- a value > 0 indicates the maximum number of preludes
Comment 1
Rob Caelers  Sep 18 2002 15:44:43 UTC
This is already the case (with one small exception, -1 == unlimited)
Comment 2
Raymond Penners  Sep 19 2002 02:45:00 UTC
It appears bugzilla is not mailing since the transition to sourceforge.
Testing, 1, 2, 3...
Comment 3
Rob Caelers  Sep 20 2002 09:23:09 UTC
Ok. done. < 0 is now unlimited.

Note: WR now always shows a prelude window before a break window. Setting
"max_preludes" to 3. Will give 4 prelude windows. The first 3 show the text
"disappears in", the last one "break in". WR will force a break after this
prelude. (this is in case force_after_preludes is true, if this is false, only 3
preludes are shown, the last one has the text "silent in")
Comment 4
Kees-Jan Dijkzeul  Sep 23 2002 02:24:26 UTC
This behaviour is very confusing. 

From a user point of view, there is not much difference between the last 
prelude and the earlier ones (I even call them the same).

So I think that the "max preludes" field should count all preludes (including 
the last one).

I thought this was what we agreed on over dinner? It's not currently 
implemented.
Comment 5
Kees-Jan Dijkzeul  Sep 23 2002 02:49:43 UTC
I'm even more confused.

The prelude window says "Break in x:xx", with x:xx some number that is counting 
down.

So I'm idle, waiting for the counter to reach zero and my break to begin. 
However, when wr detects I'm idle, it removes the prelude and shows the break 
window, apparently ahead of time.

I know this is exactly how we specced it, but still I find this confusing.
Comment 6
Rob Caelers  Sep 25 2002 13:39:56 UTC
Fixed "max_preludes" behaviour. Wrt to the "Break in x:xx": reopen bug with
alternative.