Bug 874 - Restbreak disabled inconsistently
Status:
RESOLVED FIXED
Component:
GUI
Version:
unspecified
Hardware:
All All
Importance:
P5 minor
Target Milestone:
---
Assignee:
Rob Caelers
URL:
Depends on:
Blocks:
Reported:
Nov 24 2009 08:24:33 UTC
by:
Kees-Jan Dijkzeul
Modified:
Nov 28 2009 13:42:25 UTC
WhoWhenWhatRemovedAdded
Rob CaelersNov 28 2009 13:42:25 UTCstatusNEWRESOLVED
resolutionFIXED
Description
Kees-Jan Dijkzeul  Nov 24 2009 08:24:33 UTC
I have disabled the restbreak timer in the preferences window. 

After disabling it, I was surprised to find that the microbreak window no longer has a "restbreak" button, though on second thought, it seems like a reasonable thing to do.

Then, I was surprised to find that the context menu still has the "restbreak" item. After clicking it, a restbreak window appeared (no surprises there), but the break didn't count down. The window just sits there showing exercises, but otherwise doing nothing. "Skip" to the rescue.

---

The whole thing got me thinking about what I'd like to happen in this case. When disabling restbreaks, my intent was to tell workrave not to interrupt me. However, I still would have liked to be able to self-inflict a restbreak.

Continuing this train of thought, the "enable timer" checkbox should disable all controls on the tab, except for "break duration", the "restbreak" button and menu item should not be removed, and the break window should count down the time normally.

What bothers me is that this entire thing is valid for the restbreak only. I would be much happier if we could treat all breaks the same. But we do not currently have self inflicted micro pauses or daily limits, and even if we did, the daily limit doesn't have a break duration that needs being enabled.

Any thoughts?
Comment 1
Rob Caelers  Nov 28 2009 13:42:25 UTC
- "Restbreak now" is now functional when break is disabled
- "Break duration" settings not disable when break is disabled

(commit e2c0798484c7132e33a1c1e578c56fb16eea7932)