Bug 803 - Workrave-1.9.0 fails to build in various ways.
Status:
RESOLVED FIXED
Component:
Build-Env
Version:
1.9.0
Hardware:
PC Linux
Importance:
P5 enhancement
Target Milestone:
---
Assignee:
Rob Caelers
URL:
Depends on:
Blocks:
Reported:
Dec 27 2008 14:08:11 UTC
by:
Gilles Dartiguelongue
Modified:
Dec 27 2008 18:11:17 UTC
| Id | Who | When | Size | Type |
|---|---|---|---|---|
| 156 | workrave-1.9.0-compilation-fixes.patch | |||
| Gilles Dartiguelongue | Dec 27 2008 14:08:11 UTC | 1095 | text/plain | |
| 157 | workrave-1.9.0-gcc43.patch | |||
| Gilles Dartiguelongue | Dec 27 2008 14:08:37 UTC | 1200 | text/plain | |
| 158 | workrave-1.9.0-parallel-make.patch | |||
| Gilles Dartiguelongue | Dec 27 2008 14:09:05 UTC | 1404 | text/plain | |
| 159 | workrave-1.9.0-nosoundplayer.patch | |||
| Gilles Dartiguelongue | Dec 27 2008 14:09:26 UTC | 2161 | text/plain | |
| Who | When | What | Removed | Added |
|---|---|---|---|---|
| Rob Caelers | Dec 27 2008 18:11:17 UTC | status | NEW | RESOLVED |
| resolution | FIXED |
Description
Gilles Dartiguelongue Dec 27 2008 14:08:11 UTC
Created attachment 156 workrave-1.9.0-compilation-fixes.patch Please review patches available at http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/workrave/files/ These were applied on top of 1.9.0 to allow it to build out from the tarball which : * misses a few files, * fails with parallel make (make -j4 for example), * fails with recent gcc (4.3) * and fails when there is no sound provider available some of our users disable gnome and kde support and since I disabled gstreamer due to instabilities I've had with it in the ebuild... In the nosoundplayer.patch, I've reordered the #ifdefed includes to match the order of the constructor because it makes no sense to have a different constructor than what the headers allow and vice-versa. Thanks for considering.
Comment 1
Gilles Dartiguelongue Dec 27 2008 14:08:37 UTC
Created attachment 157 workrave-1.9.0-gcc43.patch
Comment 2
Gilles Dartiguelongue Dec 27 2008 14:09:05 UTC
Created attachment 158 workrave-1.9.0-parallel-make.patch
Comment 3
Gilles Dartiguelongue Dec 27 2008 14:09:26 UTC
Created attachment 159 workrave-1.9.0-nosoundplayer.patch
Comment 4
Rob Caelers Dec 27 2008 18:11:17 UTC
Thanks! I applied all attached patches patches plus: - org.workrave.Workrave.service.in added to tarball. - workrave-gui.xml added to tarball. (not yet committed to SVN, I'm experimenting with git: http://cgit.krandor.org/cgit.cgi?url=Workrave/log/&h=branch_v1_9)