With the latest daily built, break windows are shown in the taskbar. This used not to be so.

You don't like it? :-)

It seems gtk disabled this feature...

gdk_window_set_skip_taskbar_hint says:

"
  // ### TODO: Need to figure out what to do here.
  return;
"

Added workaround... Break windows are no longr shown in the taskbar

(In reply to comment #1)
> You don't like it? :-)

I do not have a very strong opinion, other than arguing that, for consistencies sake, everything in my taskbar should correspond to a window with a title bar and stuff.

It is just that I am working on my laptop without monitor attached. Hence, my screen is so small that the break window caused my taskbar to wrap to a second line. If the effect is that obvious, I am bound to notice :-)

Thanks for fixing!

It is true that the break windows no longer appear in the taskbar, but once the windows disappear, the application that had focus before doesn't anymore.

Testcase:
- Open emacs, type until the micropause prelude appears, stop typing
- Wait until the micropause window disappears again
- Resume typing

Expected result:
- Typed characters appear in emacs

Actual result
- They don't

I suspect this is related to multi-head on windows: Yesterday, I took my laptop home, and couldn't reproduce this issue any more. Today, I'm in the office and it seems to happen consistently.

I'm testing with micropause windows, hence not self-inflicted, skip & postpone shown, no clicking anywhere, just typing, stopping at the prelude, sitting out the break, and resuming typing.

Could you try a new nightly build? I think I fixed the bug.

Confirmed fixed in last nights build.

kees-jan we might need to reopen this, can you please try 0127 and let me know if I broke anything?

----

Fix applied. Please try this recent build and tell us if you experience the same problem.

http://www.workrave.com/download/snapshots/20090127/workrave-win32-v1_9-20090127-installer.exe

Networking (add host) is broken in this build. If you do not want to install this build over your current build, you can use Universal Extractor to extract the installer files and run workrave.exe from the {app}\lib directory.

http://download.c1pher.com/uniextract16.exe

File hashes:

10507480,1096feda12b57aa68726728ac25d4a43,e23005fb2702855abc09f683899bfef531719e872a1cc2d5604934f4e0f8d03d,workrave-win32-v1_9-20090127-installer.exe

5222759,bd504eb40f1cfdd64bdeee246e45843d,ccc9e2c19ec3b41388a3fa93fa6a462fde69e16736637052dddce398d949a85b,uniextract16.exe

If you do not have a hash utility use sigcheck (digitally signed by microsoft) or md5deep/hashdeep.


Thanks,

Ray

Hi Ray,

Sorry for not getting back to you sooner. Any serious testing is best done on my work machine (it is also the only windows machine I have left), and let's say that my boss is quite good at keeping me busy.

Anyway. To summarize my tests
- Prelude windows are again shown in the task bar in dual head setup (regression)
- Break windows are again shown in the task bar in dual head setup (regression)
- Single head setups work as expected (break and prelude windows do not appear in the task bar) (Ok)
- After break windows are removed, focus is returned to the correct application (Ok)

Tests were done with the latest available daily: "workrave-win32-v1_9-20090428-installer.exe"

Hope this helps

Hmm...
I can no longer reproduce "Prelude windows are again shown in the task bar in dual head setup (regression)". The rest of my earlier comments are still valid, though.