Bug 685 - configure: misusing GTKMM_LIBS for HAVE_GLIB, == bashisms
Status:
RESOLVED FIXED
Component:
Build-Env
Version:
1.8.5
Hardware:
PC Other
Importance:
P4 normal
Target Milestone:
---
Assignee:
Rob Caelers
URL:
Depends on:
Blocks:
Reported:
Oct 2 2007 00:27:04 UTC
by:
Brian de Alwis
Modified:
Oct 15 2007 20:41:26 UTC
| Who | When | What | Removed | Added |
|---|---|---|---|---|
| Ray Satiro | Oct 2 2007 22:26:31 UTC | status | NEW | ASSIGNED |
| Rob Caelers | Oct 15 2007 20:41:26 UTC | status | ASSIGNED | RESOLVED |
| resolution | FIXED |
Description
Brian de Alwis Oct 2 2007 00:27:04 UTC
The configure scripts have two issues:
(1) in the test to determine HAVE_GLIB, they test GTKMM_LIBS. I think this should be GLIB_LIBS.
(2) there are a few bashisms involving 'test ... == ...'; POSIX sh requires this to be a single =
--- configure.ac.orig 2007-09-14 12:50:42.000000000 -0600
+++ configure.ac
@@ -119,7 +119,7 @@ AC_ARG_ENABLE( experimental,
[ --disable-experimental compile without experimental features],
config_experimental=$enableval
,
- config_experimental==yes
+ config_experimental=yes
)
dnl AC_MSG_CHECKING(whether to link statically)
@@ -460,7 +460,7 @@ AC_SUBST(GNET_LIBS)
AC_SUBST(GNET_CFLAGS)
-if test "x$GNET_LIBS" == "x"; then
+if test "x$GNET_LIBS" = "x"; then
config_distribution=no
fi
@@ -588,7 +588,7 @@ AM_GNU_GETTEXT()
#AM_GLIB_GNU_GETTEXT
dnl Hack because windows gettext package is SEVERELY broken...
-if test "x$platform_win32" == "xyes"; then
+if test "x$platform_win32" = "xyes"; then
USE_NLS=yes
AC_DEFINE(ENABLE_NLS,1,[Define to 1 if translation of program messages to the user's native
language is requested.])
@@ -719,7 +719,7 @@ if test "x$config_with_registry" = "xyes
fi
HAVE_GLIB=
-if test "x$GTKMM_LIBS" != "x"; then
+if test "x$GLIB_LIBS" != "x"; then
AC_DEFINE(HAVE_GLIB,,[Define if glib is available])
fiComment 1
Ray Satiro Oct 2 2007 22:26:31 UTC
Thank you. I don't know what the intention is with GTKMM_LIBS. Were you able to build on/for NetBSD?
Comment 2
Brian de Alwis Oct 2 2007 22:53:47 UTC
My guess is that it was the result of a partial copy-and-paste. With this patch (particularly the ==), and the patch in bug 684 (to use <sys/wait.h>, I was able to build on NetBSD.
Comment 3
Rob Caelers Oct 15 2007 20:41:26 UTC
Fixed (I rewrote most of the configure script)