Bug 531 - Memory leaks in Workrave
Status:
RESOLVED FIXED
Component:
Core :: Win32
Version:
unspecified
Hardware:
PC Windows
Importance:
P4 normal
Target Milestone:
---
Assignee:
Raymond Penners
URL:
Depends on:
Blocks:
Reported:
May 26 2006 10:14:21 UTC
by:
Frank van Boven
Modified:
Mar 25 2013 17:23:33 UTC
CC List:
Arne Babenhauserheide
JAG
my**@ho**.com
| Who | When | What | Removed | Added |
|---|---|---|---|---|
| my**@ho**.com | Feb 23 2007 09:21:54 UTC | cc | my**@ho**.com | |
| JAG | Jun 9 2007 17:06:44 UTC | cc | JAG | |
| Rob Caelers | Aug 27 2007 14:03:54 UTC | priority | P2 | P4 |
| Rob Caelers | Oct 15 2007 21:30:15 UTC | status | NEW | RESOLVED |
| resolution | FIXED | |||
| Arne Babenhauserheide | Mar 25 2013 17:23:33 UTC | cc | Arne Babenhauserheide |
Description
Frank van Boven May 26 2006 10:14:21 UTC
I've been running Workrave for almost 10 days now without reboot (I know, stupid on a Windows machine), but the memory (VM-Size) is increased from the initial 6 Mb up to 70 Mb. All options are off, only using it for the statistics. This is also the most used option.
Comment 1
jd**@gm**.com Jul 12 2006 23:05:17 UTC
(In reply to comment #0) > I've been running Workrave for almost 10 days now without reboot (I know, > stupid on a Windows machine), but the memory (VM-Size) is increased from the > initial 6 Mb up to 70 Mb. > > All options are off, only using it for the statistics. This is also the most > used option. > I have noticed this as well. I'm running Windows XP SP2, WR 1.8.2. I can watch the memory usage increase over time in Task Manager. Every couple of minutes or so, it increases by 4k. I have to shut it down from time to time to reset the memory usage. I use WR with most features turned on, and I rarely use it for statistics or open any of the menus. Just short breaks and rest breaks, with the timer displayed in the small status window. The increases don't seem to be tied to any particular event (ie, it doesn't seem to matter if I'm using the computer or not, or whether WR thinks I'm 'resting' or 'working')
Comment 2
my**@ho**.com Feb 23 2007 09:21:54 UTC
I am also experiencing this problem. Workrave has been running uninterrupted on this PC from 3/Jan/07 when it was installed to 23/Feb/07. I noticed I was running short of memory on the computer, and Workrave is almost top of my task manager list, using 126MB of memory. This is a pretty serious bug for a program designed to be left running at all times.
Comment 3
JAG Jun 9 2007 17:06:44 UTC
Rob told me in email that he made some mem leak corrections (major in exercise code) for the 1.8.4 version. I've installed the 070520 build and indeed it is so far looking a lot better than 1.8.3. I also got to know some about how he attacs the memory problem, but I wont post it here as it would be better for them to write about it. I don't know why this issue wasn't closed or marked at all from the latest changes. It was an important release, I think, but memory leaks wasn't mentioned in the release notes. --- All memory increases aren't leaks. Still I think the software could be even more careful with holding memory for a long time. Even with Paging to disk memory is a precious resource. What can be kept alive and reused in the statistics window - and how often is that opened? Current stats just now on my system with the 070520 build: 1. Just startin the app. Memory - 14.3 Mb Pagefaults - 22 each second References - 103 Threads - 1 USER-objects - 37 GDI-obj - 44 2. Open statistics window Memory - 15 Mb Pagefaults - 220 each second References - 103 Threads - 1 USER-objects - 88 GDI-obj - 54 3. Close statistics window Memory - 15,2 Mb Pagefaults - 22 each second References - 103 Threads - 1 USER-objects - 58 GDI-obj - 49 4. Open exercises from the tray menu and scroll them through with "next" and the close window. Memory - 15,5 Mb Pagefaults - 30 each second References - 103 Threads - 1 USER-objects - 58 GDI-obj - 49 5. Open and close statistics Opening raises to high numbers but goes back two the #4 numbers when closed. --- The numbers are from the Windows built in Activitymanager process info. I don't know how valid those numbers are, but I am curious about the page faults and why the startup needs 14 Mb. I guess some of the answers hide in the use of GTK.
Comment 4
Rob Caelers Oct 15 2007 21:30:15 UTC
I'm closing this bug. Quite some leaks have been fixed. This will get continued attention.