Bug 208 - Change window class for prelude/break windows
Status:
RESOLVED FIXED
Component:
GUI :: gtkmm
Version:
1.2.0
Hardware:
PC Linux
Importance:
P3 normal
Target Milestone:
---
Assignee:
Rob Caelers
URL:
Depends on:
Blocks:
Reported:
Mar 13 2003 13:31:14 UTC
by:
Rob Caelers
Modified:
Mar 15 2003 06:35:29 UTC
| Who | When | What | Removed | Added |
|---|---|---|---|---|
| Rob Caelers | Mar 14 2003 13:04:15 UTC | status | NEW | ASSIGNED |
| Rob Caelers | Mar 15 2003 03:56:56 UTC | status | ASSIGNED | RESOLVED |
| resolution | FIXED |
Description
Rob Caelers Mar 13 2003 13:31:14 UTC
"Sawfish recognizes window to shade by class name. Unfortunatelly, all windows have the same class name, and they get shaded also, resulting in... invisible window (no titlebar, or wm decorations whatsoever)." Reported by Jakub Turski.
Comment 1
Rob Caelers Mar 15 2003 03:56:56 UTC
The wmclasses of the different windows have been changed to "Workrave" (mainwindow), "WorkraveBreak" (break windows), "WorkravePreferences" (prefs window) and "WorkraveStatistics" (stats window). I'm not convinced that this is the right way... This is what the gtk+ specs say: "Don't use this function. It sets the X Window System "class" and "name" hints for a window. According to the ICCCM, you should always set these to the same value for all windows in an application, and GTK+ sets them to that value by default, so calling this function is sort of pointless."
Comment 2
Raymond Penners Mar 15 2003 04:20:27 UTC
Why go against the Gtk+ spec? IMHO, you better revert the patch. It is not up to Workrave to work around Sawfish problems if that means breaking specs (which possibly causes other problems).
Comment 3
Rob Caelers Mar 15 2003 06:35:29 UTC
It's not a sawfish problem. I checked several other programs: xmms, licq, mozilla, evolution, nautilus, the gimp, anjuta2 and gftp. They all change the wm_class hint for some windows. Some programs change only the class, others change the name, again others change both...