Bug 1224 - syntax error in workrave-dump perl script
Status:
RESOLVED FIXED
Component:
Core
Version:
daily
Hardware:
PC Linux
Importance:
P5 normal
Target Milestone:
---
Assignee:
Rob Caelers
URL:
Depends on:
Blocks:
Reported:
Nov 13 2015 15:05:54 UTC
by:
Vincent Hobeïka
Modified:
Nov 13 2015 15:56:40 UTC
IdWhoWhenSizeType
307patch to fix the workrave-dump perl script
Vincent HobeïkaNov 13 2015 15:05:54 UTC530text/plain
WhoWhenWhatRemovedAdded
Rob CaelersNov 13 2015 15:48:21 UTCstatusNEWRESOLVED
resolutionFIXED
Description
Vincent Hobeïka  Nov 13 2015 15:05:54 UTC
Created attachment 307
patch to fix the workrave-dump perl script

Hi,

I tried to use the workrave-dump from contrib in the git repository.

I encountered the following errors:
------------------------------------------------------------------------------
vincent@hal:/tmp/workrave/contrib/plot$ perl workrave-dump
"my" variable @breakstats masks earlier declaration in same scope at workrave-dump line 89.
"my" variable @DS masks earlier declaration in same scope at workrave-dump line 91.
"my" variable $key masks earlier declaration in same statement at workrave-dump line 91.
"my" variable $heartbeat masks earlier declaration in same scope at workrave-dump line 91.
"my" variable @miscstats masks earlier declaration in same scope at workrave-dump line 94.
"my" variable @DS masks earlier declaration in same scope at workrave-dump line 95.
syntax error at workrave-dump line 88, near "$breaktype qw(micro rest daily)"
syntax error at workrave-dump line 92, near "}"
Execution of workrave-dump aborted due to compilation errors.
------------------------------------------------------------------------------
------------------------------------------------------------------------------
revision tested: e71af7433710d9bbf032231aa50d021f21a71d2d
Debian GNU/Linux 8.2 (jessie)
------------------------------------------------------------------------------

Here is a patch to fix it.
I am going to set up a pull request on github if it is easier for you to incorporate into the repository.

Best regards.
Comment 1
Vincent Hobeïka  Nov 13 2015 15:20:19 UTC
My perl version:

vincent@hal:~$ perl --version

This is perl 5, version 20, subversion 2 (v5.20.2) built for x86_64-linux-gnu-thread-multi
(with 42 registered patches, see perl -V for more detail)
Comment 2
Vincent Hobeïka  Nov 13 2015 15:21:35 UTC
Pull request provided at:

https://github.com/rcaelers/workrave/pull/59

Best regards,
Comment 3
Rob Caelers  Nov 13 2015 15:48:21 UTC
Thanks! pull request merged.
Comment 4
Vincent Hobeïka  Nov 13 2015 15:56:40 UTC
Great! Thanks!