Bug 1087 - Reading Mode: During a break another break timer's time until reset may stop counting down if there's user input
Status:
RESOLVED FIXED
Component:
Core
Version:
daily
Hardware:
All All
Importance:
P5 normal
Target Milestone:
---
Assignee:
Rob Caelers
URL:
Depends on:
Blocks:
Reported:
Oct 3 2012 07:48:50 UTC
by:
Ray Satiro
Modified:
May 26 2013 00:46:04 UTC
WhoWhenWhatRemovedAdded
Rob CaelersNov 3 2012 18:29:01 UTCstatusNEWASSIGNED
Rob CaelersMay 26 2013 00:46:04 UTCstatusASSIGNEDRESOLVED
resolutionFIXED
Description
Ray Satiro  Oct 3 2012 07:48:50 UTC
Tested on commit 0b37040, "Merge pull request #28 from alick9188/trans-zh_cn"

Hey I've got one for you

1. Open timer window
2. Enable both rest and micro breaks
3. Enable reading mode
4. Take a micro break or a rest break (doesn't matter if user initiated), but make sure there's no input when the break starts because it makes the problem easier to see.
5. Wait a few seconds with no input to confirm both timers are counting down time to reset.
6. Generate input - Move the mouse around or make some clicks on something other than workrave and the countdown stops for whatever break you didn't take. For example if you're taking a micro break the countdown stops for the rest break timer. Or just the opposite if you're taking a rest break (more likely).

This is mostly an issue if during a rest break I've clicked on something or had some input during that break then the micro break won't reset and may start right after the rest break.

When activity sensitive this is not an issue because the countdown will continue when input stops.

It looks like Core is processing the timer with the new activity state of active which eventually calls Timer::start_timer() during a reading mode break. I'm not sure if that could be considered the cause or how to fix this bug.
Comment 1
Rob Caelers  Nov 3 2012 18:29:01 UTC
It seems that the 'insensitive_mode' was only changed for the timer that was responsible for the break. I'm now settings this mode on all breaks.

commit 20bf0c897f1174b1b36e76624cd9545eceb03a23
Comment 2
Rob Caelers  May 26 2013 00:46:04 UTC
It seems i forgot to set this one to resolved...